Project

General

Profile

Bug #4055

cleanup warnings in cmd/amt

Added by Igor Kozhukhov about 7 years ago. Updated about 7 years ago.

Status:
In Progress
Priority:
Normal
Category:
-
Start date:
2013-08-18
Due date:
% Done:

90%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

+ /usr/gcc/4.4/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused -Wno-empty-body -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/myshare/builds/dilos-illumos-gate/dilos-illumos-gate/proto/root_i386/usr/include -c ../amt.c 
../amt.c: In function 'probe_stack':
../amt.c:646:4: error: 'last_fail_address' may be used uninitialized in this function [-Werror=maybe-uninitialized]
../amt.c:646:18: error: 'last_fail' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
*** Error code 1
dmake: Fatal error: Command failed for target `amt.o'
Current working directory /myshare/builds/dilos-illumos-gate/dilos-illumos-gate/usr/src/cmd/amt/i386

History

#1

Updated by Igor Kozhukhov about 7 years ago

  • % Done changed from 80 to 90

it is not real bug, because we have 'j++' at line 637 and will print variables only if they are defined at lines: 638 & 639.
but it is easy to fix GCC warning at line 627 and remove '-Wno-uninitialized' for another potential issues in file.

webrev:
http://cr.dilos.org/cr/il-4055/

#2

Updated by Igor Kozhukhov about 7 years ago

  • Status changed from New to In Progress

Also available in: Atom PDF