Project

General

Profile

Bug #4095

minor cleanup up libshare

Added by Andrew Stormont over 7 years ago. Updated about 7 years ago.

Status:
In Progress
Priority:
Normal
Category:
-
Start date:
2013-09-01
Due date:
% Done:

90%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The attached patch is a minor cleanup of libshare. It fixes the following things:

1. sa_handle_impl_t and sa_handle_t are no longer separate types, although sa_handle_t is an opaque type unless libshare_impl.h is included.
2. sa_is_share, sa_is_resource, sa_group_is_zfs, sa_path_is_zfs, sa_is_persistent, sa_is_security and sa_zfs_is_shared now return boolean_t.
3. ZFS_MAXPROPLEN is used in place of MAXPATHLEN for ZFS property buffers.
4. sa_get_zfs_info has been removed because it was not used anywhere. It was also never exported.
5. libzfs_init() is now only called once, inside sa_zfs_init.


Files

libshare-cleanup.patch (50.2 KB) libshare-cleanup.patch Andrew Stormont, 2013-09-01 12:06 PM
#1

Updated by Andrew Stormont about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 90

Also available in: Atom PDF