Project

General

Profile

Actions
Copy link

Bug #4104

closed

::spa_space no longer works

Added by Christopher Siden almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Christopher Siden
Category:
zfs - Zettabyte File System
Start date:
2013-09-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Bug report by Matt Ahrens:

::spa_space fails with:
mdb: failed to read ms_allocmap from struct zfs`metaslab at ffffff02ce992e78:
only 392 of 416 bytes could be read

and then prints a bunch of garbage.  The problem is that the space_cb() was not
updated to know that type of metaslab_t::ms_map is now a pointer to a
space_map_t.

And this is why I should have switched everything to use mdb_ctf_vread() -- at
least we would have gotten a reasonable error message (something like
"incompatible type: expected space_map_t for member ms_map of struct
metaslab").

Actions
Copy link
 #1

Updated by Christopher Siden almost 9 years ago 

commit 0713e232b7712cd27d99e1e935ebb8d5de61c57d
Author: George Wilson <george.wilson@delphix.com>
Date:   Tue Oct 1 14:25:53 2013

    4101 metaslab_debug should allow for fine-grained control
    4102 space_maps should store more information about themselves
    4103 space map object blocksize should be increased
    4104 ::spa_space no longer works
    4105 removing a mirrored log device results in a leaked object
    4106 asynchronously load metaslab
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Sebastien Roy <seb@delphix.com>
    Approved by: Garrett D'Amore <garrett@damore.org>
Actions
Copy link
 #2

Updated by Christopher Siden almost 9 years ago

  • Status changed from New to Closed
commit 0713e232b7712cd27d99e1e935ebb8d5de61c57d
Author: George Wilson <george.wilson@delphix.com>
Date:   Tue Oct 1 14:25:53 2013

    4101 metaslab_debug should allow for fine-grained control
    4102 space_maps should store more information about themselves
    4103 space map object blocksize should be increased
    4104 ::spa_space no longer works
    4105 removing a mirrored log device results in a leaked object
    4106 asynchronously load metaslab
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Sebastien Roy <seb@delphix.com>
    Approved by: Garrett D'Amore <garrett@damore.org>
Actions
Copy link

Also available in: Atom PDF