Project

General

Profile

Actions

Bug #4170

closed

zhack leaves pool in ACTIVE state

Added by Christopher Siden almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2013-10-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Analysis by George Wilson:

Running the zfs test suite I noticed that the zpool_import_feature_* tests were
all failing. The test fail because the pool appears to be in use. 

A simple test reproduces this:

1). zpool create foo /var/tmp/file
2). zpool export foo
3). zhack -d /var/tmp feature enable foo com.test:xxx_unsup0
4). zpool import -d /var/tmp foo
cannot import 'foo': pool may be in use from other system
use '-f' to import anyway

There are a few problems in zhack:

1). if we've imported the pool and then call fatal() the pool is left in an
ACTIVE state
2). when we call spa_export() from zhack we are setting hardforce to B_TRUE and
that prevents us from dirtying the config so the state is never updated.
Actions #1

Updated by Christopher Siden almost 9 years ago

  • Status changed from In Progress to Closed
commit 7fdd916c474ea52896c671bbe7b56ba34a1ca132
Author: George Wilson <george.wilson@delphix.com>
Date:   Fri Oct 4 15:13:23 2013

    4168 ztest assertion failure in dbuf_undirty
    4169 verbatim import causes zdb to segfault
    4170 zhack leaves pool in ACTIVE state
    Reviewed by: Adam Leventhal <ahl@delphix.com>
    Reviewed by: Eric Schrock <eric.schrock@delphix.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Dan McDonald <danmcd@nexenta.com>
Actions

Also available in: Atom PDF