Project

General

Profile

Bug #4175

BNX driver vlan/mtu fix

Added by Patrick Domack over 5 years ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Category:
driver - device drivers
Start date:
2013-10-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

The bnx closed source driver doesn't allocate enough space for packets with vlan headers. The amount of space allocated depends on the mtu setting passed to the driver, plus normal ethernet headers. This causes the last 4 bytes to be cut off the packets if you attempt to use vlans, or you need to lower your mtu by 4 bytes, or switch to jumbo frames, and use normal 1500mtu.

This adjusts it to add 4 extra bytes to handle the vlan tag, without any of the above workarounds.
So far running this in production has not caused any issues.

edit closed/root_i386-nd/kernel/drv/bnx, exchange byte 0x1278 from 0x0e to 0x12
and, closed/root_i386-nd/kernel/drv/amd64/bnx, exchange byte 0x40b5 from 0x0e to 0x12

Related issues

Has duplicate illumos gate - Feature #8928: Want open source bnxClosed2017-12-19

Actions

History

#1

Updated by Alexandru Pirvulescu over 3 years ago

Patrick Domack wrote:

edit closed/root_i386-nd/kernel/drv/bnx, exchange byte 0x1278 from 0x0e to 0x12
and, closed/root_i386-nd/kernel/drv/amd64/bnx, exchange byte 0x40b5 from 0x0e to 0x12

The current illumos-gate 64-bit driver version (6.0.3) has the offset to be patched at 0x4185 (thanks, Patrick!). i386 seems to be the same

#2

Updated by Robert Mustacchi 4 months ago

This has been fixed with the integration of 8928. It no longer has the same problem and thankfully, editing hex will no longer be required.

#3

Updated by Robert Mustacchi 4 months ago

  • Status changed from New to Resolved
  • Assignee set to Robert Mustacchi
  • % Done changed from 0 to 100
  • Tags deleted (needs-triage)
#4

Updated by Robert Mustacchi 4 months ago

Also available in: Atom PDF