Project

General

Profile

Actions

Bug #4180

open

ixgbe probably shouldn't cast the return from ixgbe_fc_enable() to void

Added by Kevin Crowe almost 9 years ago. Updated about 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2013-10-04
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The way ixgbe is written right now it's unlikely for ixgbe_fc_enable() (and what it in turn calls) to return an error, however it's not impossible. Calls to this function should probably check the return and propagate any errors back up the stack. This was questioned in a review of changes for the fix for 4063.

Actions #1

Updated by Kevin Crowe almost 9 years ago

  • Tags deleted (needs-triage)
Actions #2

Updated by Joshua M. Clulow about 6 years ago

  • Assignee deleted (Kevin Crowe)
Actions

Also available in: Atom PDF