Project

General

Profile

Bug #4182

proto_promisc* miss calls to mac_perim_exit

Added by Robert Mustacchi over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Category:
networking
Start date:
2013-10-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While doing some development work I stumbled across an annoying bug where dld's proto_promiscon_req can miss a call to mac_perim_exit() and thus back up the rest of the system. Specifically before we validate the new requested level to add or remove we always enter the mac perimeter. However, the default case in both switch statements sends us out a failure path without releasing the mac perimeter, which leads to deadlock on the perimeter down the road. The fix is simple, make sure we in fact do this.

#1

Updated by Robert Mustacchi over 7 years ago

  • Subject changed from proto_promiscon misses calls to mac_perim_exit to proto_promis* miss calls to mac_perim_exit
#2

Updated by Robert Mustacchi over 7 years ago

  • Subject changed from proto_promis* miss calls to mac_perim_exit to proto_promisc* miss calls to mac_perim_exit
#3

Updated by Robert Mustacchi over 7 years ago

  • Status changed from Pending RTI to Resolved

Resolved in ad7ed3fec423fe5215f6da8888d44a36514ee898.

Also available in: Atom PDF