Project

General

Profile

Bug #4194

xargs feedback for -0 not included

Added by Garrett D'Amore almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Category:
cmd - userland programs
Start date:
2013-10-10
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

"Mohamed A. Khalfella" <> gave me review feedback that I accepted, but then failed to include in the final deliverable (I think largely because of the very large time delay between the review and the integration).

Specifically, the deltas recommended but omitted are here:

--- a/usr/src/cmd/xargs/xargs.c
+++ b/usr/src/cmd/xargs/xargs.c
@ -129,7 +129,7 @ static char *mav; / modified argv, after parsing
static int n_inserts; /* # of insertions. */

/* our usage message:                                                  */
-#define USAGEMSG "Usage: xargs: [-t] [-p] [-e[eofstr]] [-E eofstr] "\\
+#define USAGEMSG "Usage: xargs: [-t] [-p] [-0] [-e[eofstr]] [-E eofstr]
"[-I replstr] [-i[replstr]] [-L #] [-l[#]] [-n # [-x]] [-s size] "\\
"[cmd [args ...]]\\n"

@ -1020,6 +1020,7 @ process_special:
case 'p' :
case 't' :
case 'x' :
+ case '0' :
break;

case '-' :

These need to be included.

History

#1

Updated by Garrett D'Amore almost 7 years ago

--- a/usr/src/cmd/xargs/xargs.c
+++ b/usr/src/cmd/xargs/xargs.c
@@ -129,7 +129,7 @@ static char **mav;          /* modified argv, after parsing 
 static int     n_inserts;      /* # of insertions.                     */

 /* our usage message:                                                  */
-#define        USAGEMSG "Usage: xargs: [-t] [-p] [-e[eofstr]] [-E eofstr] "\\
+#define        USAGEMSG "Usage: xargs: [-t] [-p] [-0] [-e[eofstr]] [-E eofstr] 
        "[-I replstr] [-i[replstr]] [-L #] [-l[#]] [-n # [-x]] [-s size] "\\
        "[cmd [args ...]]\\n" 

@@ -1020,6 +1020,7 @@ process_special:
                        case 'p' :
                        case 't' :
                        case 'x' :
+                       case '0' :
                                break;

                        case '-' :
#2

Updated by Garrett D'Amore almost 7 years ago

  • Status changed from New to Pending RTI
#3

Updated by Garrett D'Amore over 6 years ago

  • Category set to cmd - userland programs
  • Status changed from Pending RTI to Resolved
  • % Done changed from 90 to 100
  • Tags deleted (needs-triage)

Resolved in 1daace1d1f6637208174834a98af2c7969517a7b

Also available in: Atom PDF