history_008_pos depends on obsolete internal history log message
zfs - Zettabyte File System
With the changes I'm working on, tests/functional/history/history_008_pos fails: stdout| 03:33:30 NOTE: Didn't find hold on testpool.8423/testfs.8423@snap with tag stderr| stdout| 03:33:30 ERROR: verify_hold zfs hold -r tag testpool.8423/testfs.8423@snap hold -i exited 1 The problem is that I updated the internal log message. Before it included "tag = <tag>", which the test is looking for. With my changes, it will have "tag=<tag>" (note lack of spaces), which is more consistent with the other history messages (e.g. for "zfs release").
Updated by Christopher Siden about 6 years ago
- Status changed from In Progress to Closed
commit f38cb554a534c6df738be3f4d23327e69888e634 Author: John Wren Kennedy <firstname.lastname@example.org> Date: Tue Dec 10 11:09:51 2013 4206 history_003_pos relies on exact size of history log and entries 4207 history_008_pos depends on obsolete internal history log message 4208 Typo in zfs_main.c: "posxiuser" 4209 Populate zfstest with the remainder of the STF tests Reviewed by: Sonu Pillai <email@example.com> Reviewed by: Will Guyette <firstname.lastname@example.org> Reviewed by: Eric Diven <email@example.com> Reviewed by: Christopher Siden <firstname.lastname@example.org> Approved by: Richard Lowe <email@example.com>