Actions
Bug #4309
openFreeBSD Clang warnings, libzfs
Status:
New
Priority:
Low
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2013-11-09
Due date:
% Done:
0%
Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
Description
Pretty minor casting/printf things for FreeBSD port of libzfs. More or less, uint64_t and int64_t should use the printf() specifier %ju or %jd for i386/amd64 happiness.
Files
Updated by Jean-Pierre André almost 9 years ago
uint64_t and int64_t should use the printf() specifier
%ju or %jd for i386/amd64 happiness.
Is there a specification for this ?
C99 section 7.8.1 defines PRId64 for formatting an int64_t (PRIu64 for a uint64_t).
Updated by sean bruno almost 9 years ago
I think, after more public review and comments, that this is "more appropriate" for the code in question. It simply looks like there's a few missing casts to longlong_t that need to be added. There's a bit of discussion about the validity of these casts in the first place and C99 does indeed specify a way to do this that is portable (see comment#2).
Actions