Project

General

Profile

Actions
Copy link

Bug #4309

open

FreeBSD Clang warnings, libzfs

Added by sean bruno over 8 years ago. Updated over 8 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2013-11-09
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Pretty minor casting/printf things for FreeBSD port of libzfs. More or less, uint64_t and int64_t should use the printf() specifier %ju or %jd for i386/amd64 happiness.

Files

Download all files
freebsd_libzfs_printf_changes.txt (8.08 KB) freebsd_libzfs_printf_changes.txt sean bruno, 2013-11-09 01:20 AM
libzfs_additional_casts_for_printf.txt (7.42 KB) libzfs_additional_casts_for_printf.txt sean bruno, 2013-11-11 06:16 PM
Actions
Copy link
 #1

Updated by Jean-Pierre André over 8 years ago

uint64_t and int64_t should use the printf() specifier
%ju or %jd for i386/amd64 happiness.

Is there a specification for this ?

C99 section 7.8.1 defines PRId64 for formatting an int64_t (PRIu64 for a uint64_t).

Actions
Copy link
 #2

Updated by sean bruno over 8 years ago

I think, after more public review and comments, that this is "more appropriate" for the code in question. It simply looks like there's a few missing casts to longlong_t that need to be added. There's a bit of discussion about the validity of these casts in the first place and C99 does indeed specify a way to do this that is portable (see comment#2).

Actions
Copy link

Also available in: Atom PDF