Project

General

Profile

Bug #4365

Bad LANG environment breaks libcurses build

Added by Theo Schlossnagle about 6 years ago. Updated over 5 years ago.

Status:
New
Priority:
Normal
Category:
lib - userland libraries
Start date:
2013-11-27
Due date:
% Done:

0%

Estimated time:
1.00 h
Difficulty:
Medium
Tags:
needs-triage

Description

The "ed" invocations in the libcurses Makefiles will produce broken output unless LANG=C. This causes terminal support to break in apps linking/relying on libcurses. ed should be invoked as "LANG=C ed"


Related issues

Related to illumos gate - Bug #4680: nightly and bldenv need to set LC_ALL if they want to fully override the localeResolved2014-03-11

Actions

History

#2

Updated by Rich Lowe about 6 years ago

You should set this in nightly.sh, along with the others, probably.

Not least because there are other places we use ed during the build, which seem like they at least could be victims as well.

#3

Updated by Garrett D'Amore over 5 years ago

Agreed with Rich; furthermore, doing the build in the C locale is likely to improve compile times modestly, as the C locale is lots more efficient than any UTF-8 locale.

This should probably also be set in bldenv. For folks that use it. Alternatively, setting the environment variable in Makefiles as well may be useful for folks that want to have tools report errors in their native language during a build. (Of course, we sort of assume that developers understand at least enough English to be productive with our source code, so they should be able to cope with English error and warning messages from compilers, etc.)

#4

Updated by Rich Lowe over 5 years ago

That'd be done in 4680 nightly and bldenv need to set LC_ALL if they want to fully override the locale

Also available in: Atom PDF