Project

General

Profile

Bug #4414

smb client may use large read/write when it should not

Added by Gordon Ross over 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2013-12-22
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

The SMB client has some code that computes when it may use "large read/write" which predated clarifications in the MS-SMB spec. about when that capability should be used. See:
http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libsmbfs/smb/ssnsetup.c#498

Since then, MS-SMB 2.2.4.5 has clarified that when SMB signing is enabled, the client should NOT use "large read/write" even though the server might offer those capabilities.

The current code disables large read/write with signing if the server looks like a Windows system, but that part of the check (is this windows) should be removed, so that the client always disables large read/write when signing is in use.


Files

illumos-4414.patch (822 Bytes) illumos-4414.patch Gordon Ross, 2013-12-22 08:57 PM

History

#2

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 94667dd268e884f0b09201a938869bc98f5862bf

commit  94667dd268e884f0b09201a938869bc98f5862bf
Author: Gordon Ross <gwr@nexenta.com>
Date:   2018-03-04T01:51:22.000Z

    4414 smb client may use large read/write when it should not
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF