Project

General

Profile

Actions

Bug #4463

closed

NLM fails wrongly on clnt_control().

Added by Dan McDonald over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
2014-01-13
Due date:
% Done:

50%

Estimated time:
1.00 h
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The new open-sourced lock manager has a place where it fails based on clnt_control() returning true:

142 /*
143 * Set the client's CLSET_NODELAYONERR option to true. The
144 * RPC clnt_call interface creates an artificial delay for
145 * certain call errors in order to prevent RPC consumers
146 * from getting into tight retry loops. Since this function is
147 * called by the NLM service routines we would like to avoid
148 * this artificial delay when possible. We do not retry if the
149 * NULL request fails so it is safe for us to turn this option
150 * on.
151 /
/
HERE IS THE BUG!!! */
152 if (clnt_control(rpcp->nr_handle, CLSET_NODELAYONERR
153 (char *)&clset)) {
154 NLM_ERR("Unable to set CLSET_NODELAYONERR\\n");
155 }


Related issues

Related to illumos gate - Bug #6156: Spurious "Unable to set CLSET_NODELAYONERR"NewDan McDonald2015-08-22

Actions
Actions #1

Updated by Dan McDonald over 7 years ago

  • Status changed from New to Resolved

commit fc2b8335a96b36a076f9614647182dd090cb6ee0
Author: Dan McDonald <>
Date: Mon Jan 13 02:38:23 2014 -0500

4463 NLM fails wrongly on clnt_control().
Reviewed by: Marcel Telka &lt;&gt;
Reviewed by: Jason King &lt;&gt;
Approved by: Garrett D'Amore &lt;&gt;
Actions #2

Updated by Marcel Telka almost 6 years ago

  • Related to Bug #6156: Spurious "Unable to set CLSET_NODELAYONERR" added
Actions

Also available in: Atom PDF