Project

General

Profile

Bug #4465

zpool(1M) is able to offline cache vdevs despite what man page says

Added by Yuri Pankov over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Yuri Pankov
Category:
manpage - manual pages
Start date:
2014-01-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

zpool(1M) is able to offline cache vdevs despite man page saying that it isn't:

       zpool offline [-t] pool device ...
           Takes the specified physical device offline. While the device is
           offline, no attempt is made to read or write to the device.

           This command is not applicable to spares or cache devices.


altair:root:~# zpool create testoff c9t67d0 cache c9t71d0
altair:root:~# zpool status testoff
  pool: testoff
 state: ONLINE
  scan: none requested
config:

        NAME        STATE     READ WRITE CKSUM
        testoff     ONLINE       0     0     0
          c9t67d0   ONLINE       0     0     0
        cache
          c9t71d0   ONLINE       0     0     0

errors: No known data errors
altair:root:~# zpool offline testoff c9t71d0
altair:root:~# zpool status testoff
  pool: testoff
 state: ONLINE
status: One or more devices has been taken offline by the administrator.
        Sufficient replicas exist for the pool to continue functioning in a
        degraded state.
action: Online the device using 'zpool online' or replace the device with
        'zpool replace'.
  scan: none requested
config:

        NAME        STATE     READ WRITE CKSUM
        testoff     ONLINE       0     0     0
          c9t67d0   ONLINE       0     0     0
        cache
          c9t71d0   OFFLINE      0     0     0

errors: No known data errors
altair:root:~#

While I'm not sure if it's implementation or documentation issue, filing it as the latter.

History

#1

Updated by Rich Lowe over 6 years ago

  • Difficulty changed from Medium to Bite-size
  • Tags deleted (needs-triage)

That's odd. schrock fixed the code with:
6687753 cache devices should support offline/online
But that predates the last open source manual pages by, like, a year.

It seems certain that the manual pages is what's wrong though, it's just a bit confusing how the copy we have is still wrong.

#2

Updated by Yuri Pankov over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Yuri Pankov
#3

Updated by Electric Monk over 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit c8323d4323a565676ba44883bfeb289d9ed8813e

commit  c8323d4323a565676ba44883bfeb289d9ed8813e
Author: Yuri Pankov <yuri.pankov@nexenta.com>
Date:   2016-03-01T14:59:29.000Z

    4465 zpool(1M) is able to offline cache vdevs despite what man page says
    5659 in the manual page for zpool(1M), one misuse of the word 'zpool' to describe a pool
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

Also available in: Atom PDF