Actions
Bug #4512
closedkclient(1m) should not depend on /usr/xpg4/bin/grep
Start date:
2014-01-21
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
The kclient(1m) script from the system/security/kerberos-5 package contains this:
1193 grep=/usr/xpg4/bin/grep 1194 1195 object=$(mktemp -q -t kclient-computer-object.XXXXXX) 1196 if [[ -z $object ]]; then 1197 printf "\\n$(gettext "Can not create temporary file, exiting").\\n 1198" >&2 1199 error_message 1200 fi 1201 1202 grep=/usr/xpg4/bin/grep ... 1429 # RC4 comes next (whether it's better than 1DES or not -- AD prefers it) 1430 if encrypt -l|$grep -q ^arcfour 1431 then 1432 ((val=val+4)) 1433 enctypes[${#enctypes[@]}]=arcfour-hmac-md5 1434 else 1435 # Use 1DES ONLY if we don't have arcfour 1436 userAccountControl=$((userAccountControl + 2097152)) 1437 fi 1438 if encrypt -l | $grep -q ^des 1439 then 1440 ((val=val+2)) 1441 enctypes[${#enctypes[@]}]=des-cbc-md5 1442 fi
There are several issues here:
- The assignment to grep variable is twice there (lines 1193 and 1202).
- The only usage of the grep variable is at lines 1430 and 1438, but there is no reason to use /usr/xpg4/bin/grep for this. Any grep available on the system (including /usr/bin/grep or /usr/gnu/bin/grep) should do the job right too.
- The /usr/xpg4/bin/grep is in system/xopen/xcu4 package, but system/security/kerberos-5 does not depend on it.
Updated by Marcel Telka over 9 years ago
- Status changed from New to In Progress
- Assignee set to Marcel Telka
Updated by Marcel Telka over 9 years ago
- Status changed from In Progress to Pending RTI
Updated by Robert Mustacchi over 9 years ago
- Status changed from Pending RTI to Resolved
- % Done changed from 0 to 100
- Tags deleted (
needs-triage)
Resolved in f7dbdfc7b241e42b135dc9118e41b127cb935483.
Actions