Project

General

Profile

Actions

Bug #4527

open

Duplication of code between sbdadm.c and stmfadm.c

Added by Sam Zaydel over 7 years ago. Updated over 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2014-01-24
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

It seems that stmfadm and sbdadm have a lot of the same code, for example blocks of code following these two lines are doing the same exact thing. It seems as though this duplication could lead to one being updated and one not, if one of the APIs they use is for some reason changed. This may not be a bug, but may be a good idea to think about whether the two commands really should be one command line interface.

http://src.illumos.org/source/xref/illumos-gate/usr/src/cmd/stmfadm/stmfadm.c#863

http://src.illumos.org/source/xref/illumos-gate/usr/src/cmd/sbdadm/sbdadm.c#139

Actions #1

Updated by Yuri Pankov over 5 years ago

sbdadm(1M) man page lists it as "Obsolete Commited", stmfadm(1M) does everything sbdadm(1M) can and a lot more, so there's nothing to fix here, other than removing sbdadm.

Actions

Also available in: Atom PDF