Actions
Bug #4529
openrange_tree_{add,remove} panic messages are misleading
Status:
New
Priority:
Normal
Assignee:
-
Category:
zfs - Zettabyte File System
Start date:
2014-01-25
Due date:
% Done:
0%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
The panic messages in these two range tree functions are accurate if and only if the range tree passed to them is tracking allocated space. In at least the case where we are in space_map_load(…, SM_FREE) via metaslab_load(), the sense is inverted: if we encounter this condition in range_tree_add(), it is because we are freeing a free segment and conversely in range_tree_remove() because we are allocating an allocated one.
We probably should return a status code from these functions that indicates specifically that we failed due to an exact match, and let the caller decide how to communicate the semantics of that failure.
No data to display
Actions