Project

General

Profile

Actions

Bug #4554

closed

memory leak in ndmpd_config_get_fs_info_v3

Added by Jan Kryl over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
cmd - userland programs
Start date:
2014-01-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
NDMP
Gerrit CR:

Description

There is a memory leak in error code path in ndmpd_config_get_fs_info_v3 (around line 626 fsip->fs_logical_device and fsip->fs_type are not freed). Also the code in this functions begs for restructuring and could be optimized to open /etc/mnttab just once instead of twice.

Actions #1

Updated by Jan Kryl over 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 100
Actions #2

Updated by Jan Kryl over 7 years ago

  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk over 7 years ago

git commit 3ed73a35f260311604b6a106c2de1e8488499ff8

Author: Albert Lee <trisk@nexenta.com>

4554 memory leak in ndmpd_config_get_fs_info_v3
Reviewed by: Jan Kryl <jan.kryl@nexenta.com>
Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>

Actions #4

Updated by Robert Mustacchi over 7 years ago

  • Status changed from Pending RTI to Resolved
Actions

Also available in: Atom PDF