Bug #4554: memory leak in ndmpd_config_get_fs_info_v3 - illumos gate - illumos

Actions

Copy link

Bug #4554

closed

memory leak in ndmpd_config_get_fs_info_v3

Added by Jan Kryl over 9 years ago. Updated over 9 years ago.

Status:

Resolved

Priority:

Low

Assignee:

Jan Kryl

Category:

cmd - userland programs

Start date:

2014-01-31

Due date:

% Done:

100%

Estimated time:

Difficulty:

Bite-size

Tags:

NDMP

Gerrit CR:

External Bug:

Description

There is a memory leak in error code path in ndmpd_config_get_fs_info_v3 (around line 626 fsip->fs_logical_device and fsip->fs_type are not freed). Also the code in this functions begs for restructuring and could be optimized to open /etc/mnttab just once instead of twice.

Actions

Copy link

Updated by Jan Kryl over 9 years ago

Status changed from New to In Progress
% Done changed from 0 to 100

Actions

Copy link

Updated by Jan Kryl over 9 years ago

Status changed from In Progress to Pending RTI

Actions

Copy link

Updated by Electric Monk over 9 years ago

git commit 3ed73a35f260311604b6a106c2de1e8488499ff8

Author: Albert Lee <trisk@nexenta.com>

4554 memory leak in ndmpd_config_get_fs_info_v3
Reviewed by: Jan Kryl <jan.kryl@nexenta.com>
Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Approved by: Richard Lowe <richlowe@richlowe.net>

Actions

Copy link