Project

General

Profile

Actions

Bug #4574

closed

get_clones_stat does not call zap_count in non-debug kernel

Added by Alexander Stetsenko over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-02-05
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

zap_count is enclosed in ASSERT0 macro, which is empty for non-debug kernel.
VERIFY0 macro should be used instead.

Actions #1

Updated by Anonymous over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Alexander Stetsenko
  • % Done changed from 0 to 100

zap_count(...) is never called in non-DEBUG kernel.
As result "count" variable is always 0, and "goto fail" is always reached.
This means get_clones_stat function never makes up list of clones for "clones" properties.
The fix is simple - just to replace ASSERT0 on VERIFY0.

Actions #2

Updated by Electric Monk over 7 years ago

git commit 03d1795fa6f720eafbee821ad37f4343c391cfe4

Author: Alexander Stetsenko <astetsenko@racktopsystems.com>

4574 get_clones_stat does not call zap_count in non-debug kernel
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Marcel Telka <marcel@telka.sk>
Approved by: Gordon Ross <gwr@nexenta.com>

Actions #3

Updated by Alexander Stetsenko over 7 years ago

  • Category set to zfs - Zettabyte File System
  • Status changed from In Progress to Pending RTI
Actions #4

Updated by Alexander Stetsenko over 7 years ago

  • Status changed from Pending RTI to Resolved
Actions

Also available in: Atom PDF