Project

General

Profile

Bug #4594

uts/common/io/zyd/zyd_usb.c uses hex identifiers for devices, should use *BSD usbdevs.h ?

Added by Ben Taylor almost 7 years ago. Updated almost 7 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
2014-02-11
Due date:
% Done:

50%

Estimated time:
3.00 h
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The hardware identifiers used in common/io/zyd/zyd_usb.c uses hex identifiers for specific hardware, but this makes it very difficult to understand which devices these correspond to.

*BSD has a usbdev.h file which uses defines to identify the manufacturer, and the specific devices. Since one of the projects identified on the Illumos page is to tie net80211 and wifi devices more closely to their origins in *BSD, this seems like a reasonable first step.

#1

Updated by Ben Taylor almost 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 50

usbdevs.h gets generated from the usr/src/uts/common/io/usb/usbdevs file by the usr/src/uts/common/io/usb/usbdevs2h.awk script, as part of the build of the usr/src/uts/common/sys/Makefile.

Should be able to unwind the hardcoded hexadecimal identifiers for devices in zyd_usb.c to use the defines in the usbdevs.h file

Also available in: Atom PDF