Project

General

Profile

Bug #4616

igb has uninitialized kstats

Added by Garrett D'Amore over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Category:
driver - device drivers
Start date:
2014-02-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The igb driver has numerous kstats that are uninitialized -- which causes garbage to be displayed by kstat(1M) for them.

Furthermore, many kstats it keeps here are simply duplicates of values that are reported via the GLDv3 statistics.

We should not keep these in separate named kstats, but rather just use local variables to track them. This has a few benefits:

  • fix the uninitialized kstats
  • avoid confusion about which values are "real"
  • reduce one more level of dereferencing
  • reduce total size consumed (uint64_t is smaller than kstat_named_t)

Related issues

Related to illumos gate - Feature #4431: igb support for I354Resolved2013-12-24

Actions

History

#1

Updated by Electric Monk over 6 years ago

git commit 13485e69b5429e6c7d27301fb3c0deee0e93768a

Author: Garrett D'Amore <garrett@damore.org>

4431 igb support for I354
4616 igb has uninitialized kstats
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Rafael Vanoni <rafael.vanoni@pluribusnetworks.com>
Reviewed by: Michael Speer <michael.speer@pluribusnetworks.com>
Approved by: Robert Mustacchi <rm@joyent.com>

#2

Updated by Garrett D'Amore over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 90 to 100

commit 13485e69b5429e6c7d27301fb3c0deee0e93768a
Author: Garrett D'Amore <>
Date: Thu Feb 20 17:23:15 2014 -0800

4431 igb support for I354
4616 igb has uninitialized kstats
Reviewed by: Robert Mustacchi &lt;&gt;
Reviewed by: Dan McDonald &lt;&gt;
Reviewed by: Rafael Vanoni &lt;&gt;
Reviewed by: Michael Speer &lt;&gt;
Approved by: Robert Mustacchi &lt;&gt;

Also available in: Atom PDF