Project

General

Profile

Feature #4621

support newer (bugfixed) bcrypt version

Added by Rich Lowe over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2014-02-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

OpenBSD bug-fixed their implementation of bcrypt in a way that requires a new version for the hash ($2b$), if we wish to interoperate with such hashes, we need to make the same bug fix. Presumably $2b$ will spread, as others do the same thing.

http://marc.info/?l=openbsd-misc&m=139320023202696

The logical test to any fix would be whether it interoperates with the OpenBSD implementation.


Files

bsdbf.diff (1.84 KB) bsdbf.diff Patrick Domack, 2014-02-25 04:48 AM
test-vectors.txt (4.49 KB) test-vectors.txt Patrick Domack, 2014-03-07 08:13 PM

History

#1

Updated by Rich Lowe over 6 years ago

The OpenBSD diffs are: http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/bcrypt.c.diff?r1=1.26;r2=1.27;f=h

(and possibly 1.28 as an addendum, but I didn't check that actual diff)

#2

Updated by Patrick Domack over 6 years ago

Attached patch.

#3

Updated by Patrick Domack over 6 years ago

Add test vectors.

Diff isn't good. posted to webrev.

http://www.patrickdk.com/webrev/bsdbf-bcrypt/

#4

Updated by Electric Monk over 6 years ago

git commit 00d0b46c9fa449579f084579de169b055d3ef18c

Author: Patrick Domack <patrickdk@patrickdk.com>

4621 support newer (bugfixed) bcrypt version
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Garrett D'Amore <garrett@damore.org>

#5

Updated by Garrett D'Amore over 6 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100
  • Tags deleted (needs-triage)

Also available in: Atom PDF