Bug #4623

Remove -Wno-unused-label from mpt_sas

Added by Dan McDonald over 3 years ago. Updated over 3 years ago.

Status:ResolvedStart date:2014-02-24
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Difficulty:Medium Tags:needs-triage

Description

While investigating #4403, I discovered a quick-fix to remove a gcc override from mpt_sas's Makefile.

diff --git a/usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_raid.c b/usr/src
index a9e2109..e64ca18 100644
--- a/usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_raid.c
+++ b/usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas_raid.c
@@ -464,7 +464,6 @@ mptsas_get_raid_wwid(mptsas_t *mpt, mptsas_raidvol_t *raidvo
                raidvol->m_raidwwid = sas_wwn;
        }

-done:
        return (rval);
 }

diff --git a/usr/src/uts/intel/mpt_sas/Makefile b/usr/src/uts/intel/mpt_sas/Make
index ed09c9f..5e1d881 100644
--- a/usr/src/uts/intel/mpt_sas/Makefile
+++ b/usr/src/uts/intel/mpt_sas/Makefile
@@ -62,7 +62,6 @@ include $(UTSBASE)/intel/Makefile.intel

 CERRWARN       += -_gcc=-Wno-parentheses
 CERRWARN       += -_gcc=-Wno-uninitialized
-CERRWARN       += -_gcc=-Wno-unused-label
 CERRWARN       += -_gcc=-Wno-switch

 #

History

#1 Updated by Dan McDonald over 3 years ago

The sparc Makefile probably needs it too.

#2 Updated by Electric Monk over 3 years ago

git commit 5a8d3db1a9faa71e948f85f673574967cfdad948

Author: Dan McDonald <danmcd@omniti.com>

4623 Remove -Wno-unused-label from mpt_sas
Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
Reviewed by: Albert Lee <trisk@nexenta.com>
Approved by: Robert Mustacchi <rm@joyent.com>

#3 Updated by Dan McDonald over 3 years ago

  • Status changed from New to Resolved

See above.

Also available in: Atom