Project

General

Profile

Actions
Copy link

Bug #4630

closed

clean stale references to ddi_iopb_alloc and ddi_iopb_free

Added by Garrett D'Amore over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Garrett D'Amore
Category:
manpage - manual pages
Start date:
2014-02-26
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The fix for 998 removed the obsolete ddi_iopb_alloc and ddi_iopb_free interfaces.

Unfortunately, it left behind some incorrect comments (particularly in the scsi/conf/device.h header) and a number of stale man pages. (Actually the man pages were introduced into the gate after 998 was integrated.)

We should clean these up.

Marking this as man-page, since that's where the most references are, but I'd like to point out that various code comments, and the warlock files, all need to have this removed.

Also, ddi_mem_alloc and ddi_mem_free references should be removed (found in warlock)

Actions
Copy link
 #1

Updated by Garrett D'Amore over 9 years ago

  • Assignee set to Garrett D'Amore

I'll go ahead and clean these up.

Actions
Copy link
 #2

Updated by Garrett D'Amore over 9 years ago

I'll go ahead and clean these up.

While here, I notice that ddi_dma_req.9s still exists, but there are no documented (public) functions which still can use this structure. We should just nuke that man page -- this should have been done when the legacy DMA routines went away.

Actions
Copy link
 #3

Updated by Electric Monk over 9 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b89e420ae1290e425c29db875ec0c0546006eec7

commit  b89e420ae1290e425c29db875ec0c0546006eec7
Author: Garrett D'Amore <garrett@damore.org>
Date:   2014-06-10T03:26:06.000Z

    4888 Undocument dma_req(9s)
    4884 EOF scsi_hba_attach
    4886 EOF ddi_dmae_getlim
    4887 EOF ddi_iomin
    4634 undocument scsi_hba_attach() and ddi_dma_lim(9s)
    4630 clean stale references to ddi_iopb_alloc and ddi_iopb_free
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF