zvol_get_stats triggering too many reads
zfs - Zettabyte File System
Original analysis by Matt Ahrens:
The problem is that when a dataset is last closed (e.g. a filesystem is unmounted), we need to get rid of all its state in the DMU (dbufs, dnodes, etc). This needs to be coordinated with the ARC (because the arc bufs have pointers to these data structures too). We end up evicting all the data out of the ARC. This results in very bad performance for things like "zfs get all" if some filesystems/zvols/snapshots are not mounted (or for zvols, are not open / exported by comstar), because every snapshot's objset will be opened (to get the zpl/zvol props), read, and then closed (which will be the last close, evicting all the data from the ARC). When the next snapshot is opened, it probably shares all its relevant blocks with the previous snapshot, but we just explicitly evicted all of those blocks from the ARC. So we end up repeatedly reading in the same blocks from disk. The fix is to change the interaction between the DMU and ARC so that when the DMU is shutting down an objset, we do not evict the data from the ARC. Instead we simply coordinate the destruction of the DMU's data with the ARC. The only case where we actually need to explicitly evict from the ARC is when dbuf_rele_and_unlock() determines that the administrator has requested that it not be kept in memory, via the primarycache/secondarycache properties. In this case, we evict the data from the ARC by its blkptr_t, the same way as when a block is freed we explicitly evict it from the ARC.
Updated by Electric Monk over 5 years ago
- Status changed from In Progress to Closed
commit bbfa8ea8bb4168c969ba27d632dfe0aeec3fc0da Author: Matthew Ahrens <firstname.lastname@example.org> Date: 2014-07-17T17:27:14.000Z 4631 zvol_get_stats triggering too many reads Reviewed by: Adam Leventhal <email@example.com> Reviewed by: Sebastien Roy <firstname.lastname@example.org> Reviewed by: Matt Ahrens <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>