Project

General

Profile

Bug #4738

tape block number is set at wrong place

Added by Jan Kryl over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Jan Kryl
Category:
cmd - userland programs
Start date:
2014-04-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
NDMP
Gerrit CR:

Description

Currently tape block number is reset in a thread which waits for mover continue event. In theory if there are n threads waiting for mover continue event then tape block number will be reset n-times. It should be reset in thread which emits mover continue event, because that's the thread which modifies mover state and other threads should access the modified state in read-only mode.

While it doesn't constitute a bug, it confuses readers of the code and from algorithmic point of view it's wrong and should be fixed.

History

#1

Updated by Marcel Telka over 6 years ago

  • Subject changed from tape block number should be reset on to tape block number is set at wrong place
#2

Updated by Jan Kryl over 6 years ago

  • Status changed from New to Pending RTI
  • % Done changed from 0 to 100
#3

Updated by Electric Monk over 6 years ago

git commit f5b1cef2488dc579cb4312d49164f10debf8e97d

Author: Jan Kryl <jan.kryl@nexenta.com>

4738 tape block number is set at wrong place
Reviewed by: Albert Lee <trisk@nexenta.com>
Approved by: Dan McDonald <danmcd@omniti.com>

#4

Updated by Dan McDonald over 6 years ago

  • Status changed from Pending RTI to Resolved

See above.

Also available in: Atom PDF