Project

General

Profile

Bug #4756

metaslab_group_preload() could deadlock

Added by Christopher Siden over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-04-14
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

George Wilson:

I noticed that metaslab_group_preload() grabs the mg_lock and then later tries
to grab the metaslab lock. This lock ordering may lead to a deadlock since
other consumers of the mg_lock will grab the metaslab lock first.

History

#1

Updated by Christopher Siden over 5 years ago

  • Status changed from New to Pending RTI
#2

Updated by Christopher Siden over 5 years ago

  • Status changed from Pending RTI to In Progress
#3

Updated by Christopher Siden over 5 years ago

  • Status changed from In Progress to Feedback
#4

Updated by Christopher Siden over 5 years ago

  • Status changed from Feedback to In Progress
#5

Updated by Christopher Siden over 5 years ago

  • Status changed from In Progress to Pending RTI
#6

Updated by Christopher Siden over 5 years ago

  • Status changed from Pending RTI to Resolved
#7

Updated by Electric Monk over 5 years ago

  • Status changed from Resolved to Closed

git commit 30beaff42d8240ebf5386e8b7a14e3d137a1631f

commit  30beaff42d8240ebf5386e8b7a14e3d137a1631f
Author: George Wilson <george.wilson@delphix.com>
Date:   2014-06-12T23:29:11.000Z

    4756 metaslab_group_preload() could deadlock
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Christopher Siden <christopher.siden@delphix.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF