Project

General

Profile

Bug #4780

comstar iSCSI target shouldn't abuse ddi_get_time(9f)

Added by Josef Sipek over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
comstar - iSCSI/FC/SAS target
Start date:
2014-04-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

ddi_get_time() returns a Unix timestamp based on the current TOD. If the TOD setting changes for whatever reason (daylight saving time adjustments, NTP), the value returned by ddi_get_time() may change non-monotonically. This makes it unsuitable for calculating timeouts and wait times.


Related issues

Related to illumos gate - Bug #4776: man: don't lie about ddi_get_time(9f) usesClosed2014-04-17

Actions

History

#1

Updated by Electric Monk over 5 years ago

  • % Done changed from 80 to 100
  • Status changed from New to Closed

git commit 55a3a0ef881a0e1c7da841d46bb5878758497dc1

commit  55a3a0ef881a0e1c7da841d46bb5878758497dc1
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-05-14T23:37:21.000Z

    4780 comstar iSCSI target shouldn't abuse ddi_get_time(9f)
    Reviewed by: Eric Diven <eric.diven@delphix.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF