Project

General

Profile

Bug #4787

ipf: remove rate_limit_message

Added by Josef Sipek almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
networking
Start date:
2014-04-21
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

This is an unused function that has several issues:

(1) it uses ddi_get_item(9f) to rate limit instead of gethrtime(9f) or ddi_get_lbolt(9f)

(2) it calls cmn_err/fprintf with a user supplied buffer which could contain format escape sequences causing invalid pointer dereferences leading to kernel panics


Related issues

Related to illumos gate - Bug #4776: man: don't lie about ddi_get_time(9f) usesClosed2014-04-17

Actions

History

#1

Updated by Electric Monk almost 5 years ago

  • % Done changed from 80 to 100
  • Status changed from New to Closed

git commit 12928d597a28b7743c3fc254b6fcfc05560c1720

commit  12928d597a28b7743c3fc254b6fcfc05560c1720
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-05-14T23:37:52.000Z

    4787 ipf: remove rate_limit_message
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: David Höppner <0xffea@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF