Project

General

Profile

Actions

Bug #4808

closed

libnsl: SI_SRPC_DOMAIN is always defined

Added by Marcel Telka over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
lib - userland libraries
Start date:
2014-04-25
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

In the usr/src/lib/libnsl/rpc/getdname.c file there is this piece of code:

48#include <sys/systeminfo.h>
49#include <sys/time.h>
50#include <syslog.h>
51
52#ifndef SI_SRPC_DOMAIN
53#define    use_file
54#endif

The SI_SRPC_DOMAIN is defined unconditionally in sys/systeminfo.h and there is no way how the SI_SRPC_DOMAIN would become undefined at line 52.

This means that use_file is never defined in getdname.c and thus we could remove several lines of code from getdname.c.

Actions #1

Updated by Marcel Telka over 8 years ago

  • Status changed from In Progress to Pending RTI
Actions #2

Updated by Electric Monk over 8 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit c5953fd0a23d8a0dc9475dfa76ad0dfd07663717

commit  c5953fd0a23d8a0dc9475dfa76ad0dfd07663717
Author: Marcel Telka <marcel.telka@nexenta.com>
Date:   2014-05-01T00:55:07.000Z

    4808 libnsl: SI_SRPC_DOMAIN is always defined
    Reviewed by: Andy Stormont <AStormont@racktopsystems.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF