Project

General

Profile

Actions
Copy link

Bug #4838

closed

Fix for 4596 has some inverted booleans

Added by Dan McDonald about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2014-05-02
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

The results of post-4596's ip_srcid_find_id() are TRUE when there's a v4mapped/v6only MATCH between srcid and the desired type of address.

Some callers, notably in UDP, throw an error upon TRUE, which is wrong.

The toy C program, which reflects one UDP datagram on an unspecified, but port-bound AF_INET6 socket, demonstrates this bug.

Files

inet6-mapped.c (1.4 KB) inet6-mapped.c Dan McDonald, 2014-05-02 09:07 PM

Related issues

Related to illumos gate - Bug #4596: Callers of ip_srcid_find_id() need to be more carefulResolvedDan McDonald2014-02-13

Actions
Actions
Copy link
 #1

Updated by Electric Monk about 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 14b7b4606a1faf7fc4c0bbcc2946782d6538850e

commit  14b7b4606a1faf7fc4c0bbcc2946782d6538850e
Author: Dan McDonald <danmcd@omniti.com>
Date:   2014-05-05T15:13:58.000Z

    4838 Fix for 4596 has some inverted booleans
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF