illumos gate

Hi, OpenBSD dev here (mostly a porter but I dabble in various things); I was pointed at this ticket and just wanted to mention a few things..

Note that OpenBSD's calloc/reallocarray have specific checks against overflows. I don't know my way around the Illumos codebase but if the relevant calloc code is that in https://github.com/illumos/illumos-gate/blob/master/usr/src/lib/libmapmalloc/common/calloc.c, this will need a little more work to give the guarantees that LibreSSL is expecting. http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/stdlib/reallocarray.c?rev=1.1

Another thing LibreSSL is depending on is the current OpenBSD arc4random functionality (http://mdoc.su/o/arc4random) - note the automatic reseeding behaviour and use of sysctl rather than device node that's being done here (the latter avoid problems under FD exhaustion type situations and with chroot).

So it turns out that there are a bunch of additional interfaces required for C11 (a bunch of interfaces that come with _s and the rsize_t type, as well as a conditional extension, etc.)

I'm going to leave memset_s, and the other _s versions, out of this changeset, to be addressed at a later date as part of a different changeset.

We do need to get those C11 interfaces added to our libc, of course.

Btw, libc's calloc is a bit better than the one you found in mapmalloc: (libc's calloc is in libc/port/gen/calloc) -- I think this meets the needs of libressl.

void *
calloc(size_t num, size_t size)
{
        void *mp;
        size_t total;

        if (num == 0 || size == 0)
                total = 0;
        else {
                total = num * size;

                /* check for overflow */
                if (total / num != size) {
                        errno = ENOMEM;
                        return (0);
                }
        }
        return ((mp = malloc(total)) ? memset(mp, 0, total) : mp);
}

I just tried to compile latest libressl-portable 2.5.0 and I was able to compile. Was this added in the meantime or did I miss something? Perhaps, libressl-portable provides missing interfaces.

AFAIK only explicit_bzero has been added so far.

#5428 added reallocarray().