Project

General

Profile

Bug #4902

4839, 3294 introduced build breakage on older Illumos build machines

Added by Sašo Kiselkov almost 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
2014-05-31
Due date:
% Done:

90%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The fix for issues 4839 and 3294 ("generated elfdump struct layouts by hand, shouldn't have", commit 894fa7ba) broke the build of gen_struct_layout in usr/src/cmd/sgs/elfdump on older Illumos machines:
../common/gen_struct_layout.c: In function 'gen_prfdinfo':
../common/gen_struct_layout.c:560: error: 'prfdinfo_t' undeclared (first use in this function)
This happens because prfdinfo_t is declared in sys/procfs.h, but the author of the fix forgot to add the appropriate CPPFLAGS for the build target environment into the Makefile rules, so the build was picking up the older sys/procfs.h from the host system instead (which lacked the structure definition). Newer Illumos machines that ship with a newer sys/procfs.h aren't affected, but older (oi_151a7) are.


Related issues

Related to illumos gate - Bug #5106: elfdump compiles using headers from the build systemClosed2014-08-19

Actions

History

#1

Updated by Gordon Ross about 5 years ago

  • Status changed from New to Closed

The fix for #5106 also fixed this. (Perhaps #5106 was a dup of this bug - sorry.)

Also available in: Atom PDF