Project

General

Profile

Actions
Copy link

Bug #4914

closed

zfs on-disk bookmark structure should be named *_phys_t

Added by Christopher Siden over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Christopher Siden
Category:
zfs - Zettabyte File System
Start date:
2014-06-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

Matt Ahrens:

ZFS data structures that are stored on disk should follow the naming convention
of being *_phys_t.  This helps avoid confusion when reading/modifying the code
(e.g. see ZFS on Linux commit:
https://github.com/zfsonlinux/zfs/commit/1421c89)

Actions
Copy link
 #1

Updated by Sašo Kiselkov over 9 years ago

Please rename the bug description from "zfs on-disk structures should be name *_phys_t" to "zfs on-disk structures for bookmarks should be named *_phys_t". Besides the obvious grammatical typo, the original issue description implies that more structure names may have changed than just zbookmark_t. Accurate descriptions help when searching through "git log".

Actions
Copy link
 #2

Updated by Christopher Siden over 9 years ago

  • Subject changed from zfs on-disk structures should be name *_phys_t to zfs on-disk bookmark structure should be named *_phys_t
Actions
Copy link
 #3

Updated by Electric Monk over 9 years ago

  • Status changed from In Progress to Closed

git commit 7802d7bf98dec568dadf72286893b1fe5abd8602

commit  7802d7bf98dec568dadf72286893b1fe5abd8602
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2014-06-25T18:38:00.000Z

    4914 zfs on-disk bookmark structure should be named *_phys_t
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Reviewed by: Christopher Siden <christopher.siden@delphix.com>
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Actions
Copy link

Also available in: Atom PDF