zfs on-disk bookmark structure should be named *_phys_t
ZFS data structures that are stored on disk should follow the naming convention of being *_phys_t. This helps avoid confusion when reading/modifying the code (e.g. see ZFS on Linux commit: https://github.com/zfsonlinux/zfs/commit/1421c89)
Updated by Sašo Kiselkov almost 7 years ago
Please rename the bug description from "zfs on-disk structures should be name *_phys_t" to "zfs on-disk structures for bookmarks should be named *_phys_t". Besides the obvious grammatical typo, the original issue description implies that more structure names may have changed than just zbookmark_t. Accurate descriptions help when searching through "git log".
Updated by Electric Monk almost 7 years ago
- Status changed from In Progress to Closed
commit 7802d7bf98dec568dadf72286893b1fe5abd8602 Author: Matthew Ahrens <email@example.com> Date: 2014-06-25T18:38:00.000Z 4914 zfs on-disk bookmark structure should be named *_phys_t Reviewed by: George Wilson <firstname.lastname@example.org> Reviewed by: Christopher Siden <email@example.com> Reviewed by: Richard Lowe <firstname.lastname@example.org> Reviewed by: Saso Kiselkov <email@example.com> Approved by: Robert Mustacchi <firstname.lastname@example.org>