Actions
Bug #4955
closedlibshare's get_zfs_dataset need not sort the datasets
Start date:
2014-07-02
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
Description
libshare's get_zfs_dataset need not sort the datasets
sorting them is quite expensive, because the sorting func calls libzfs to get
the mountpoints. Inside the loop we do exact matching on mountpoints, so
there's no point to sorting.
Updated by Electric Monk about 8 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 33cde0d0c27645bc9ec94c4d2955193c3dd4027c
commit 33cde0d0c27645bc9ec94c4d2955193c3dd4027c Author: Matthew Ahrens <mahrens@delphix.com> Date: 2014-07-08T04:12:40.000Z 4953 zfs rename <snapshot> need not involve libshare 4954 "zfs create" need not involve libshare if we are not sharing 4955 libshare's get_zfs_dataset need not sort the datasets Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Sebastien Roy <sebastien.roy@delphix.com> Reviewed by: Dan McDonald <danmcd@omniti.com> Reviewed by: Gordon Ross <gordon.ross@nexenta.com> Approved by: Garrett D'Amore <garrett@damore.org>
Actions