Project

General

Profile

Bug #4962

libnsl: unused variable in clnt_dg_geterr()

Added by Marcel Telka over 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
lib - userland libraries
Start date:
2014-07-03
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

The local variable cu is unused in clnt_dg_geterr() and should be removed:

682static void
683clnt_dg_geterr(CLIENT *cl, struct rpc_err *errp)
684{
685/* LINTED pointer alignment */
686    struct cu_data *cu = (struct cu_data *)cl->cl_private;
687
688    *errp = rpc_callerr;
689}

History

#1

Updated by Shruti Sampat almost 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Shruti Sampat
#2

Updated by Shruti Sampat almost 6 years ago

Marcel,

Is there anyway that you tested this? I fixed the issue, but I am trying to figure out how to test it. Because I do not see warnings in my builds before and after fix. Also, is there any test program that you have used?

I built and verified the fix by looking at the build logs. Is that good enough? Please suggest.

#3

Updated by Marcel Telka almost 6 years ago

Shruti Sampat wrote:

Marcel,

Is there anyway that you tested this? I fixed the issue, but I am trying to figure out how to test it. Because I do not see warnings in my builds before and after fix. Also, is there any test program that you have used?

Sorry, no.

I built and verified the fix by looking at the build logs. Is that good enough? Please suggest.

That should be enough.

#4

Updated by Electric Monk almost 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit b7ab9363c6e2655569be4922a449075200c3d990

commit  b7ab9363c6e2655569be4922a449075200c3d990
Author: Shruti Sampat <shrutisampat@gmail.com>
Date:   2014-11-19T21:08:20.000Z

    4962 libnsl: unused variable in clnt_dg_geterr()
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF