Project

General

Profile

Bug #4974

spa_load_verify() reads all data twice

Added by Matthew Ahrens over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-07-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

"zpool import FX" requires that we scrub all data in the pool. However, we
read all user data twice -
once when the traversal code prefetches it, and
then again when we scrub it. We should not prefetch the user data, because we
do not access it again via the ARC.

History

#1

Updated by Electric Monk over 5 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit e42d205944d245bf5d1c4fc45261cbe09e28a7b9

commit  e42d205944d245bf5d1c4fc45261cbe09e28a7b9
Author: Matthew Ahrens <mahrens@delphix.com>
Date:   2014-07-15T18:58:42.000Z

    4970 need controls on i/o issued by zpool import -XF
    4971 zpool import -T should accept hex values
    4972 zpool import -T implies extreme rewind, and thus a scrub
    4973 spa_load_retry retries the same txg
    4974 spa_load_verify() reads all data twice
    Reviewed by: Christopher Siden <christopher.siden@delphix.com>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Reviewed by: George Wilson <george.wilson@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF