Feature #5015

improvements to mpt_sas debug logging and mdb module

Added by Hans Rosenfeld about 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:2014-07-17
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:-
Target version:-
Difficulty:Medium Tags:needs-triage

Description

Along with the 12G support for mpt_sas, Andy Giles created a set of changes to improve the mpt_sas debug logging to be more useful, and he also made improvements to the mdb module for mpt_sas.

pre.log Magnifier - mdb -k ::mptsas before the changes (3.2 KB) Hans Rosenfeld, 2014-09-04 01:42 PM

post.log Magnifier - mdb -k ::mptsas after the changes (13.6 KB) Hans Rosenfeld, 2014-09-04 01:42 PM

History

#1 Updated by Hans Rosenfeld about 3 years ago

webrev: http://ma.nexenta.com/~woodstock/illumos-mptsas-dbg/

The changes include a few bits of cleanup in the existing messages mpt_sas prints, plus a few new messages. The mdb module received a bit of cleanup, and now prints additional information. The flag to display command slots (-s) does now work, although only when used in kmdb and on core dumps.

Also, Andy added debug log ring buffer, only active in debug mode. Debug messages can be logged to this buffer, a new tunable selects which messages are logged. This should have less impact on a system than printing them to the console and system log. The debug log ring buffer can be viewed with mdb ::mptsas.

#2 Updated by Electric Monk almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 50c4511157ef5d522f0c717eef41fe9ddb58f171

commit  50c4511157ef5d522f0c717eef41fe9ddb58f171
Author: Andy Giles <illumos@ang.homedns.org>
Date:   2014-10-02T15:26:38.000Z

    5015 improvements to mpt_sas debug logging and mdb module
    Reviewed by: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom