Bug #5047

don't use atomic_*_nv if you discard the return value

Added by Josef Sipek over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:2014-07-28
Priority:LowDue date:
Assignee:Josef Sipek% Done:

100%

Category:kernel
Target version:-
Difficulty:Bite-size Tags:needs-triage

Description

The _nv atomic functions are more complex and slower than their simpler non-_vn cousins. If you don't care about the return value, just use the simpler and faster functions.

History

#1 Updated by Electric Monk over 3 years ago

  • % Done changed from 90 to 100
  • Status changed from New to Closed

git commit 640c1670a105457bb0040e8e11037b53ab6ebcfa

commit  640c1670a105457bb0040e8e11037b53ab6ebcfa
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-08-12T18:36:39.000Z

    5047 don't use atomic_*_nv if you discard the return value
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom