Bug #5062
Feature #5061: freebsd boot loader integration (loader project)
bootadm update-archive should not fail if grub1 is missing
| Status: | Closed | Start date: | 2014-08-01 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Toomas Soome | % Done: | 100% | |
| Category: | cmd - userland programs | |||
| Target version: | - | |||
| Difficulty: | Bite-size | Tags: | needs-triage |
Description
bootadm fails to update the boot archive if there is no <mountpoint>/boot/grub/stage2 file. This failure happens because of is_grub() check in bootadm_upgrade.c: get _findroot_cap().
This check is redundant and unneeded, because is_grub() check is only needed for menu management, and bam_menu(), which is used to call all menu related functions, is using is_grub() check before doing anything else.
History
#1
Updated by Toomas Soome over 4 years ago
in addition to get_findroot_cap(), also the get_boot_cap() is using is_grub() check.
#2
Updated by Toomas Soome over 4 years ago
- % Done changed from 0 to 90
- Status changed from New to In Progress
#3
Updated by Electric Monk over 4 years ago
- % Done changed from 90 to 100
- Status changed from In Progress to Closed
git commit 630270564f9cfe09ebbccb748c7dc1d897e14135
commit 630270564f9cfe09ebbccb748c7dc1d897e14135
Author: Toomas Soome <tsoome@me.com>
Date: 2014-09-10T21:59:23.000Z
5062 bootadm update-archive should not fail if grub1 is missing
Reviewed by: Gary Mills <gary_mills@fastmail.fm>
Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Also available in: Atom