Actions
Bug #5062
closedFeature #5061: freebsd boot loader integration (loader project)
bootadm update-archive should not fail if grub1 is missing
Start date:
2014-08-01
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
Description
bootadm fails to update the boot archive if there is no <mountpoint>/boot/grub/stage2 file. This failure happens because of is_grub() check in bootadm_upgrade.c: get _findroot_cap().
This check is redundant and unneeded, because is_grub() check is only needed for menu management, and bam_menu(), which is used to call all menu related functions, is using is_grub() check before doing anything else.
Updated by Toomas Soome almost 8 years ago
in addition to get_findroot_cap(), also the get_boot_cap() is using is_grub() check.
Updated by Toomas Soome over 7 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 90
Updated by Electric Monk over 7 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit 630270564f9cfe09ebbccb748c7dc1d897e14135
commit 630270564f9cfe09ebbccb748c7dc1d897e14135 Author: Toomas Soome <tsoome@me.com> Date: 2014-09-10T21:59:23.000Z 5062 bootadm update-archive should not fail if grub1 is missing Reviewed by: Gary Mills <gary_mills@fastmail.fm> Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com> Approved by: Richard Lowe <richlowe@richlowe.net>
Actions