Project

General

Profile

Bug #5087

8-bit inline atomic {add,or,and} use wrong reg constraints on x86

Added by Josef Sipek over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2014-08-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

5044 introduced a possible compile-time issue. The 8-bit ops must use the "q" register constraint since 32-bit code cannot handle certain registers (e.g., %sil).

(Really, gcc should be smart enough to know better, but this is the way it behaves.)

#1

Updated by Josef Sipek over 6 years ago

  • Subject changed from 8-bit inline atomic {add,or,and} uses wrong reg constraint on x86 to 8-bit inline atomic {add,or,and} use wrong reg constraints on x86
#2

Updated by Electric Monk over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 30 to 100

git commit d8ccf998f9c944b8cf27ed840c376f9b79ebce5c

commit  d8ccf998f9c944b8cf27ed840c376f9b79ebce5c
Author: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
Date:   2014-08-14T14:29:42.000Z

    5087 8-bit inline atomic {add,or,and} use wrong reg constraints on x86
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Also available in: Atom PDF