Project

General

Profile

Bug #5148

zvol's DKIOCFREE holds zfsdev_state_lock too long

Added by Matthew Ahrens about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
zfs - Zettabyte File System
Start date:
2014-09-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

When zvol processes a DKIOCFREE (e.g. SCSI UNMAP), it holds the zfsdev_state_lock (a global lock) across the call to dmu_free_long_range(), which can take a long time. We can safely drop this lock earlier.

History

#1

Updated by Electric Monk almost 5 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 574e2414ac6a50c9d6097c2e4a98eb9263f90c44

commit  574e2414ac6a50c9d6097c2e4a98eb9263f90c44
Author: George Wilson <george.wilson@delphix.com>
Date:   2014-09-16T20:01:54.000Z

    5148 zvol's DKIOCFREE holds zfsdev_state_lock too long
    Reviewed by: Matthew Ahrens <mahrens@delphix.com>
    Reviewed by: Paul Dagnelie <paul.dagnelie@delphix.com>
    Reviewed by: Sebastien Roy <sebastien.roy@delphix.com>
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Dan McDonald <danmcd@omniti.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF