Project

General

Profile

Actions
Copy link

Feature #5151

closed

blkdev should support reporting of physical block size

Added by Hans Rosenfeld almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Hans Rosenfeld
Category:
driver - device drivers
Start date:
2014-09-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

It would be really useful for SSDs and virtio-block devices if blkdev would support reporting of a physical block size in DKIOCGMEDIAINFOEXT. This would allow ZFS to use the correct ashift for the underlying device.

Also, blkdev does currently only honor media.m_solidstate if the underlying device also indicates a block size > 512b. I don't think this is correct or intentional. I noticed when working on the skd driver (not upstream yet), which uses a 512b block size throughout, but it is a SSD and I think it's reasonable to assume that it uses at least 4k blocks internally.

Actions
Copy link
 #1

Updated by Hans Rosenfeld almost 8 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from blkdev sometimes ignores media.m_solidstate to blkdev should support reporting of physical block size
Actions
Copy link
 #2

Updated by Electric Monk almost 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 32ce6b819524e8719d4ce58db40a00e9f17843e2

commit  32ce6b819524e8719d4ce58db40a00e9f17843e2
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Date:   2014-09-12T19:17:32.000Z

    5151 blkdev should support reporting of physical block size
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF