Project

General

Profile

Bug #5191

webrev wdiff assumes line numbers are <10000

Added by Josef Sipek almost 6 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
tools - gate/build tools
Start date:
2014-09-22
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Webrev's wdiff output assumes that line numbers are smaller than 10000 by padding them to 4 characters (IOW, "%4d"). This works fine on most files, however any time a large file (e.g., sd.c) gets modified the output is... suboptimal.

Example:
http://31bits.net/illumos/cr/4781-sd-shouldnt-abuse-ddi_get_time-9f/usr/src/uts/common/io/scsi/targets/sd.c.wdiff.html

Also available in: Atom PDF