Project

General

Profile

Bug #5233

nightly lock files should use an invalid character as a separator

Added by Rich Lowe almost 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
tools - gate/build tools
Start date:
2014-10-15
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

At present, the target of nightly's lock file links is separated by a '.'. That's a valid (somewhat questionably, admittedly) character in a hostname or nodename.

This is why sometimes nightly will tell you that it's already running, but get both the hostname and username of the person running it entirely incorrect. You have a '.' in what nightly thinks of as your hostname.

We could make nightly parse them from the RHS, and be immune to any problems this causes, but it'd be much easier (and probably smarter) to use a character which is not otherwise valid as a separator.

The only downside is that the old and new versions of nightly wouldn't lock eachother out.

Also available in: Atom PDF