Project

General

Profile

Feature #5240

Update CMake to 2.8.12.2

Added by Aurélien Larcher almost 6 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
2014-10-16
Due date:
% Done:

100%

Estimated time:
1.00 h
Difficulty:
Medium
Tags:
needs-triage

Description

Current version is 2.8.6.
I propose an update to 2.8.12.2 which is the latest minor from the 2.8 series.

Patches are already updated in my Github branch named 'cmake' and is working fine as far as I could test it, but some tests fail due to missing libraries at linking stage.

https://github.com/alarcher/oi-userland/tree/cmake

99% tests passed, 4 tests failed out of 311

Label Time Summary:
Label1    =   0.08 sec
Label2    =   0.08 sec

Total Test time (real) = 523.84 sec

The following tests FAILED:
     25 - FindModulesExecuteAll (Failed)
    223 - CMakeOnly.AllFindModules (Failed)
    248 - RunCMake.VisibilityPreset (Failed)
    302 - CMake.ProcessorCount (Failed)
Errors while running CTest

Files

cmake-2.8.12.2_tests.txt (40.1 KB) cmake-2.8.12.2_tests.txt Aurélien Larcher, 2014-10-22 04:12 PM

History

#1

Updated by Aurélien Larcher almost 6 years ago

Added gmake test output.

#2

Updated by Ken Mays over 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 70 to 90

Aurelien:
I'm using cmake 2.8.12.2 to build scribus 1.5.0 and it seems to work well - even though I got the same 4 test errors (99% pass).
Nothing service impacting at the moment.
$ uname -a
SunOS testbot illumos-4e90188 i86pc i386 i86pc Solaris

$ cmake -version
cmake version 2.8.12.2

#3

Updated by Igor Pashev over 5 years ago

Index: cmake-3.0.2/Modules/ProcessorCount.cmake
===================================================================
--- cmake-3.0.2.orig/Modules/ProcessorCount.cmake
+++ cmake-3.0.2/Modules/ProcessorCount.cmake
@@ -169,6 +169,20 @@ function(ProcessorCount var)
     endif()
   endif()

+  if(NOT count)
+    # Sun prtconf
+    find_program(ProcessorCount_cmd_prtconf prtconf)
+    mark_as_advanced(ProcessorCount_cmd_prtconf)
+    if(ProcessorCount_cmd_prtconf)
+      execute_process(COMMAND ${ProcessorCount_cmd_prtconf}
+        ERROR_QUIET
+        OUTPUT_STRIP_TRAILING_WHITESPACE
+        OUTPUT_VARIABLE prtconf_output)
+        string(REGEX MATCHALL "cpu, *instance *#([0-9]+)" procs "${prtconf_output}")
+      list(LENGTH procs count)
+    endif()
+  endif()
+
   # Execute this code when all previously attempted methods return empty
   # output:
   #

Or something like this.

#4

Updated by Ken Mays about 5 years ago

IPS updated to: ,5.11-2015.0.1.0:20150611T165357Z

#5

Updated by Alexander Pyhalov about 5 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Aurélien Larcher to Josef Sipek
  • % Done changed from 90 to 100

Also available in: Atom PDF