Project

General

Profile

Bug #5246

xdr_uid_t/xdr_gid_t cleanups

Added by Marcel Telka almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
nfs - NFS server and client
Start date:
2014-10-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

Both xdr_uid_t and xdr_gid_t are defined in usr/src/lib/libnsl/rpc/authsys_prot.c (in libnsl library; for userland) and in usr/src/uts/common/rpc/sec/authu_prot.c (in rpcsec module; for kernel). The prototypes are declared in usr/src/uts/common/rpc/auth_sys.h (for both kernel and libnsl).

There are few places in the illumos sources where we have duplicate declarations of xdr_uid_t/xdr_gid_t. They are not needed there, so we should remove them.

In addition, in both nfsauth_xdr.c and nfs_auth_xdr.c there are XDR functions working with UIDs/GIDs, but instead of xdr_uid_t/xdr_gid_t, the xdr_u_int() is used.

History

#1

Updated by Marcel Telka almost 5 years ago

  • Status changed from In Progress to Pending RTI
#2

Updated by Electric Monk almost 5 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit a05fd0c9b9aa46cf66ddea7617e56facdf1f4aaf

commit  a05fd0c9b9aa46cf66ddea7617e56facdf1f4aaf
Author: Marcel Telka <marcel.telka@nexenta.com>
Date:   2014-10-21T21:22:04.000Z

    5246 xdr_uid_t/xdr_gid_t cleanups
    Reviewed by: David Höppner <0xffea@gmail.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF