Project

General

Profile

Actions
Copy link

Bug #5262

closed

libm needs to be carefully unifdef'd

Added by Rich Lowe over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
lib - userland libraries
Start date:
2014-10-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

There are a bunch of things in libm that are #ifdef'd, sometimes with #else branches, where the actually used code is constant in our tree.

ELFOBJ seems one, __INLINE another. These should be carefully unifdef'd, and then wsdiff'd to be sure that nothing actually changes.

Actions
Copy link
 #1

Updated by Rich Lowe over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Rich Lowe
  • Difficulty changed from Medium to Bite-size
Actions
Copy link
 #2

Updated by Electric Monk over 8 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 1ec68d336ba97cd53f46053ac10401d16014d075

commit  1ec68d336ba97cd53f46053ac10401d16014d075
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2014-11-26T22:05:42.000Z

    5262 libm needs to be carefully unifdef'd
    5268 libm doesn't need to hide symbols which are already local
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Gordon Ross <gwr@nexenta.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions
Copy link

Also available in: Atom PDF