Project

General

Profile

Actions

Bug #5268

closed

libm doesn't need to hide symbols which are already local

Added by Rich Lowe almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2014-10-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

libm namespaces a bunch of symbols with __libm that are nevertheless also private.

It appears to be doing this to prevent collisions with libsunmath or libmopt, neither of which will occur, since the symbols are scoped local.

The namespace-y hacks should be removed

Actions #1

Updated by Electric Monk almost 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 1ec68d336ba97cd53f46053ac10401d16014d075

commit  1ec68d336ba97cd53f46053ac10401d16014d075
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2014-11-26T22:05:42.000Z

    5262 libm needs to be carefully unifdef'd
    5268 libm doesn't need to hide symbols which are already local
    Reviewed by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
    Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>
    Reviewed by: Gordon Ross <gwr@nexenta.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF