Project

General

Profile

Actions
Copy link

Bug #5278

closed

cleanup gcc warnings for cmd/ps

Added by Igor Kozhukhov over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Igor Kozhukhov
Category:
-
Start date:
2014-11-01
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

+ /usr/gcc/4.8/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused-local-typedefs -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/myshare/builds/ssd02/builds/dilos-illumos.update/proto/root_i386/usr/include -c ../ps.c

../ps.c: In function 'stdmain':
../ps.c:914:3: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
   while (dentp = readdir(dirp)) {
   ^
cc1: all warnings being treated as errors
*** Error code 1

+ /usr/gcc/4.8/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused-local-typedefs -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/myshare/builds/ssd02/builds/dilos-illumos.update/proto/root_i386/usr/include -c ../ucbps.c 
../ucbps.c: In function 'ucbmain':
../ucbps.c:399:2: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
  while (dentp = readdir(dirp)) {
  ^
cc1: all warnings being treated as errors
*** Error code 1

+ /usr/gcc/4.8/bin/gcc -fident -finline -fno-inline-functions -fno-builtin -fno-asm -fdiagnostics-show-option -nodefaultlibs -D__sun -O -m32 -Wall -Wextra -Werror -Wno-missing-braces -Wno-sign-compare -Wno-unknown-pragmas -Wno-unused-parameter -Wno-missing-field-initializers -Wno-array-bounds -Wno-unused-local-typedefs -std=gnu89 -fno-inline-small-functions -fno-inline-functions-called-once -fno-ipa-cp -DTEXT_DOMAIN="SUNW_OST_OSCMD" -D_TS_ERRNO -I/myshare/builds/ssd02/builds/dilos-illumos.update/proto/root_i386/usr/include -c ../ps.c 
../ps.c: In function 'print_field':
../ps.c:1938:11: error: 'csave' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    *csave = c;
           ^
../ps.c:1938:11: error: 'c' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
*** Error code 1
Actions
Copy link
 #1

Updated by Igor Kozhukhov over 8 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 80
Actions
Copy link
 #2

Updated by Igor Kozhukhov over 8 years ago

  • % Done changed from 80 to 90
Actions
Copy link
 #3

Updated by Igor Kozhukhov over 8 years ago

  • Status changed from In Progress to Pending RTI
  • % Done changed from 90 to 100
Actions
Copy link
 #4

Updated by Electric Monk over 8 years ago

  • Status changed from Pending RTI to Closed

git commit e503abb729687d1a36b95ed2794f54452189c858

commit  e503abb729687d1a36b95ed2794f54452189c858
Author: Igor Kozhukhov <ikozhukhov@gmail.com>
Date:   2014-11-13T03:08:39.000Z

    5278 cleanup gcc warnings for cmd/ps
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Reviewed by: Keith Wesolowski <keith.wesolowski@joyent.com>
    Reviewed by: Josef 'Jeff' Sipek <josef.sipek@nexenta.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@omniti.com>

Actions
Copy link

Also available in: Atom PDF